Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisarnjs
reviewed
Jun 30, 2024
| userToken: string | ||
| ) => { | ||
| const response = await fetch(`${BASE_URL}/links`, { | ||
| method: "POST", |
There was a problem hiding this comment.
HTTP메소드들도 함수 util로 분리한다면 fetch 함수를 사용하는데 더 확장성 있게 사용할 수 있을거에요!
export const post = async (url, body) => {
return await fetch(`${BASE_URL}{url}`, {
method: 'POST',
headers: {},
body: body
})
}
export const addLink = () => {
const body = JSON.stringify({
url: linkUrl,
folderId: folderId,
})
return post('/links', body)
}| const userInfo = useContext(UserInfoContext); | ||
|
|
||
| const changeInputFolderName = (e: React.ChangeEvent<HTMLInputElement>) => { | ||
| setFolderName(e.target.value); |
There was a problem hiding this comment.
e.target vs e.currentTarget의 차이점을 아시나요?!
👇🏻혹시 모르신다면 아래를 참고해주세요!
https://velog.io/@sunkim/Javascript-e.target%EA%B3%BC-e.currentTarget%EC%9D%98-%EC%B0%A8%EC%9D%B4%EC%A0%90
| @@ -39,11 +48,40 @@ const LinkAddContent = () => { | |||
| setFolder(selectedFoler.current[i]); | |||
| }; | |||
|
|
|||
| const handleLinkAdd = useMutation({ | |||
| mutationFn: () => { | |||
| if (!userInfo || !userInfo.token) { | |||
There was a problem hiding this comment.
옵셔널 체이닝을 여기서 사용해도 좋겠어요!
!userInfo?.token
| handleLinkDelete.mutate(); | ||
| }; | ||
|
|
||
| const handleLinkDelete = useMutation({ |
There was a problem hiding this comment.
요런 react query를 사용해서 데이터를 업데이트하는 로직도 커스텀 훅으로 빼면 더 좋을 거 같아요 👍
| localStorage.setItem("userToken", result.data.accessToken); | ||
| setUserToken(result.data.accessToken); | ||
| localStorage.setItem("userToken", result.accessToken); | ||
| setUserToken(result.accessToken); |
There was a problem hiding this comment.
로컬에 저장하는데 state에도 저장하는 이유가 따로 있을까요??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
기본
주요 변경사항
멘토에게